Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JPERF-1081: Extend AsyncProfiler stop timeout #154

Merged
merged 1 commit into from
May 17, 2023
Merged

JPERF-1081: Extend AsyncProfiler stop timeout #154

merged 1 commit into from
May 17, 2023

Conversation

dagguh
Copy link
Contributor

@dagguh dagguh commented Apr 20, 2023 •
edited
Loading

Fix errors like:

Caused by: java.lang.Exception: SSH command exceeded timeout PT30S by PT2.861S
	at com.atlassian.performance.tools.ssh.WaitingCommand.waitForCompletion(WaitingCommand.kt:43) ~[ssh-2.4.3.jar:?]
	at com.atlassian.performance.tools.ssh.WaitingCommand.waitForResult(WaitingCommand.kt:21) ~[ssh-2.4.3.jar:?]
	at com.atlassian.performance.tools.ssh.SshjConnection.safeExecute(SshjConnection.kt:63) ~[ssh-2.4.3.jar:?]
	at com.atlassian.performance.tools.ssh.SshjConnection.safeExecute(SshjConnection.kt:52) ~[ssh-2.4.3.jar:?]
	at com.atlassian.performance.tools.ssh.SshjConnection.execute(SshjConnection.kt:33) ~[ssh-2.4.3.jar:?]
	at com.atlassian.performance.tools.ssh.api.SshConnection.execute(SshConnection.kt:27) ~[ssh-2.4.3.jar:?]
	at com.atlassian.performance.tools.infrastructure.api.profiler.AsyncProfiler$ProfilerProcess.stop(AsyncProfiler.kt:42) ~[infrastructure-4.24.0.jar:?]
	at com.atlassian.performance.tools.awsinfrastructure.api.jira.StartedNode.gatherResults(StartedNode.kt:23) ~[aws-infrastructure-2.29.0.jar:?]
	at com.atlassian.performance.tools.awsinfrastructure.api.jira.Jira$gatherResults$1$1.invoke(Jira.kt:34) ~[aws-infrastructure-2.29.0.jar:?]
	at com.atlassian.performance.tools.awsinfrastructure.api.jira.Jira$gatherResults$1$1.invoke(Jira.kt:14) ~[aws-infrastructure-2.29.0.jar:?]
	... 6 more

I guess that longer profiling session can take more time to dump the data into a flamegraph.

@dagguh dagguh requested a review from a team as a code owner April 20, 2023 11:14
pczuj
pczuj previously approved these changes Apr 20, 2023
View reviewed changes
@pczuj
Copy link
Contributor

pczuj commented May 15, 2023 •
edited
Loading

We wanted to test atlassian/aws-infrastructure#163 and we faced the problem that this timeout increase change could address. Apparently if we fail on stopping the profiler then we fail to gather other results/diagnostics, however the test by itself may go on.

It would help to push it forward.

@pczuj
Copy link
Contributor

pczuj commented May 15, 2023

Looked at what failed on CI: https://scans.gradle.com/s/kyyx6rpd2464y

Both failed tests broke on some docker communication issue. Will be worth diagnosting at some point, however for now I will allow myself to retry the test believeing that it will work this time.

@pczuj
Copy link
Contributor

pczuj commented May 15, 2023

Apparently the MySQL CI problem should be already fixed on master branch. We should rebase this PR.

@ewefie
Copy link
Contributor

ewefie commented May 16, 2023

50 s timeout might not be enough. I used your branch to build a test library but the error persisted.

@dagguh dagguh force-pushed the issue/JPERF-1081-extend-async-profiler-timeout branch from 0e43add to e919ca2 Compare May 17, 2023 08:23
@dagguh dagguh merged commit 96f41b1 into master May 17, 2023
@dagguh dagguh deleted the issue/JPERF-1081-extend-async-profiler-timeout branch May 17, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pczuj pczuj pczuj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dagguh @pczuj @ewefie